OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i965: Drop PIPE_CONTROL_NO_WRITE from various calls.

Browse Source 
This is just zero - passing nothing already gives us a post-sync
operation of "nothing".

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
This commit is contained in:
Kenneth Graunke
2017-11-16 23:43:48 -08:00
parent 5f21a7afe0
commit 2c01215c1b
4 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mesa/drivers/dri/i965/brw_misc_state.c
View File

@@ -462,15 +462,13 @@ brw_emit_select_pipeline(struct brw_context *brw, enum brw_pipeline pipeline)
PIPE_CONTROL_RENDER_TARGET_FLUSH | PIPE_CONTROL_RENDER_TARGET_FLUSH |
PIPE_CONTROL_DEPTH_CACHE_FLUSH | PIPE_CONTROL_DEPTH_CACHE_FLUSH |
dc_flush | dc_flush |
PIPE_CONTROL_NO_WRITE |
PIPE_CONTROL_CS_STALL); PIPE_CONTROL_CS_STALL);
brw_emit_pipe_control_flush(brw, brw_emit_pipe_control_flush(brw,
PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE | PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE |
PIPE_CONTROL_CONST_CACHE_INVALIDATE | PIPE_CONTROL_CONST_CACHE_INVALIDATE |
PIPE_CONTROL_STATE_CACHE_INVALIDATE | PIPE_CONTROL_STATE_CACHE_INVALIDATE |
PIPE_CONTROL_INSTRUCTION_INVALIDATE | PIPE_CONTROL_INSTRUCTION_INVALIDATE);
PIPE_CONTROL_NO_WRITE);
} else { } else {
/* From "BXML » GT » MI » vol1a GPU Overview » [Instruction] /* From "BXML » GT » MI » vol1a GPU Overview » [Instruction]

2
src/mesa/drivers/dri/i965/brw_pipe_control.c
View File

@@ -547,7 +547,7 @@ brw_emit_mi_flush(struct brw_context *brw)
OUT_BATCH(0); OUT_BATCH(0);
ADVANCE_BATCH(); ADVANCE_BATCH();
} else { } else {
int flags = PIPE_CONTROL_NO_WRITE | PIPE_CONTROL_RENDER_TARGET_FLUSH; int flags = PIPE_CONTROL_RENDER_TARGET_FLUSH;
if (devinfo->gen >= 6) { if (devinfo->gen >= 6) {
flags |= PIPE_CONTROL_INSTRUCTION_INVALIDATE | flags |= PIPE_CONTROL_INSTRUCTION_INVALIDATE |
PIPE_CONTROL_CONST_CACHE_INVALIDATE | PIPE_CONTROL_CONST_CACHE_INVALIDATE |

4
src/mesa/drivers/dri/i965/brw_program.c
View File

@@ -277,9 +277,7 @@ brw_memory_barrier(struct gl_context *ctx, GLbitfield barriers)
{ {
struct brw_context *brw = brw_context(ctx); struct brw_context *brw = brw_context(ctx);
const struct gen_device_info *devinfo = &brw->screen->devinfo; const struct gen_device_info *devinfo = &brw->screen->devinfo;
unsigned bits = (PIPE_CONTROL_DATA_CACHE_FLUSH | unsigned bits = PIPE_CONTROL_DATA_CACHE_FLUSH | PIPE_CONTROL_CS_STALL;
PIPE_CONTROL_NO_WRITE |
PIPE_CONTROL_CS_STALL);
assert(devinfo->gen >= 7 && devinfo->gen <= 11); assert(devinfo->gen >= 7 && devinfo->gen <= 11);
if (barriers & (GL_VERTEX_ATTRIB_ARRAY_BARRIER_BIT | if (barriers & (GL_VERTEX_ATTRIB_ARRAY_BARRIER_BIT |

5
src/mesa/drivers/dri/i965/gen7_l3_state.c
View File

@@ -86,7 +86,6 @@ setup_l3_config(struct brw_context *brw, const struct gen_l3_config *cfg)
*/ */
brw_emit_pipe_control_flush(brw, brw_emit_pipe_control_flush(brw,
PIPE_CONTROL_DATA_CACHE_FLUSH | PIPE_CONTROL_DATA_CACHE_FLUSH |
PIPE_CONTROL_NO_WRITE |
PIPE_CONTROL_CS_STALL); PIPE_CONTROL_CS_STALL);
/* ...followed by a second pipelined PIPE_CONTROL that initiates /* ...followed by a second pipelined PIPE_CONTROL that initiates
@@ -107,15 +106,13 @@ setup_l3_config(struct brw_context *brw, const struct gen_l3_config *cfg)
PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE | PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE |
PIPE_CONTROL_CONST_CACHE_INVALIDATE | PIPE_CONTROL_CONST_CACHE_INVALIDATE |
PIPE_CONTROL_INSTRUCTION_INVALIDATE | PIPE_CONTROL_INSTRUCTION_INVALIDATE |
PIPE_CONTROL_STATE_CACHE_INVALIDATE | PIPE_CONTROL_STATE_CACHE_INVALIDATE);
PIPE_CONTROL_NO_WRITE);
/* Now send a third stalling flush to make sure that invalidation is /* Now send a third stalling flush to make sure that invalidation is
* complete when the L3 configuration registers are modified. * complete when the L3 configuration registers are modified.
*/ */
brw_emit_pipe_control_flush(brw, brw_emit_pipe_control_flush(brw,
PIPE_CONTROL_DATA_CACHE_FLUSH | PIPE_CONTROL_DATA_CACHE_FLUSH |
PIPE_CONTROL_NO_WRITE |
PIPE_CONTROL_CS_STALL); PIPE_CONTROL_CS_STALL);
if (devinfo->gen >= 8) { if (devinfo->gen >= 8) {