From 29baa326b93345634f4e8b49c0ffbec52761a778 Mon Sep 17 00:00:00 2001 From: Yonggang Luo Date: Sat, 7 May 2022 09:59:44 +0800 Subject: [PATCH] microsoft/spirv_to_dxil: Fixes maybe-uninitialized compiling error in dxil_spirv_nir.c Fixes following errors: ../src/microsoft/spirv_to_dxil/dxil_spirv_nir.c In file included from ../src/compiler/nir/nir_builder.h:365, from ../src/microsoft/compiler/dxil_nir.h:29, from ../src/microsoft/spirv_to_dxil/dxil_spirv_nir.c:28: ../src/microsoft/spirv_to_dxil/dxil_spirv_nir.c: In function 'dxil_spirv_nir_passes': src/compiler/nir/nir_builder_opcodes.h:1321:11: error: 'dyn_yz_flip_mask' may be used uninitialized in this function [-Werror=maybe-uninitialized] 1321 | return nir_build_alu2(build, nir_op_iand, src0, src1); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/microsoft/spirv_to_dxil/dxil_spirv_nir.c:290:59: note: 'dyn_yz_flip_mask' was declared here 290 | nir_ssa_def *y_flip_mask = NULL, *z_flip_mask = NULL, *dyn_yz_flip_mask; | ^~~~~~~~~~~~~~~~ Signed-off-by: Yonggang Luo Reviewed-by: Jesse Natalie Reviewed-by: Erik Faye-Lund Part-of: --- src/microsoft/spirv_to_dxil/dxil_spirv_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/microsoft/spirv_to_dxil/dxil_spirv_nir.c b/src/microsoft/spirv_to_dxil/dxil_spirv_nir.c index 72f70ce70b7..5f0f8a5994f 100644 --- a/src/microsoft/spirv_to_dxil/dxil_spirv_nir.c +++ b/src/microsoft/spirv_to_dxil/dxil_spirv_nir.c @@ -286,7 +286,7 @@ lower_yz_flip(struct nir_builder *builder, nir_instr *instr, nir_ssa_def *pos = nir_ssa_for_src(builder, intrin->src[1], 4); nir_ssa_def *y_pos = nir_channel(builder, pos, 1); nir_ssa_def *z_pos = nir_channel(builder, pos, 2); - nir_ssa_def *y_flip_mask = NULL, *z_flip_mask = NULL, *dyn_yz_flip_mask; + nir_ssa_def *y_flip_mask = NULL, *z_flip_mask = NULL, *dyn_yz_flip_mask = NULL; if (rt_conf->yz_flip.mode & DXIL_SPIRV_YZ_FLIP_CONDITIONAL) { // conditional YZ-flip. The flip bitmask is passed through the vertex