OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/fs: Slightly restructure emitting nir_op_imul_32x16 and nir_op_umul_32x16

Browse Source 
There are no immediate values at this point, so all of this code was
bunk. :face_palm:

Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19602>
This commit is contained in:
Ian Romanick
2021-02-08 18:49:06 -08:00
committed by Marge Bot
parent ee2a299661
commit 293ad13e3f
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/intel/compiler/brw_fs_nir.cpp
View File

@@ -1316,6 +1316,10 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr,
case nir_op_imul_32x16: case nir_op_imul_32x16:
case nir_op_umul_32x16: { case nir_op_umul_32x16: {
const bool ud = instr->op == nir_op_umul_32x16; const bool ud = instr->op == nir_op_umul_32x16;
const enum brw_reg_type word_type =
ud ? BRW_REGISTER_TYPE_UW : BRW_REGISTER_TYPE_W;
const enum brw_reg_type dword_type =
ud ? BRW_REGISTER_TYPE_UD : BRW_REGISTER_TYPE_D;
assert(nir_dest_bit_size(instr->dest.dest) == 32); assert(nir_dest_bit_size(instr->dest.dest) == 32);
@@ -1325,18 +1329,10 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr,
*/ */
assert(devinfo->ver >= 7); assert(devinfo->ver >= 7);
if (op[1].file == IMM) /* Before copy propagation there are no immediate values. */
op[1] = ud ? brw_imm_uw(op[1].ud) : brw_imm_w(op[1].d); assert(op[0].file != IMM && op[1].file != IMM);
else {
const enum brw_reg_type word_type =
ud ? BRW_REGISTER_TYPE_UW : BRW_REGISTER_TYPE_W;
op[1] = subscript(op[1], word_type, 0);
}
const enum brw_reg_type dword_type =
ud ? BRW_REGISTER_TYPE_UD : BRW_REGISTER_TYPE_D;
op[1] = subscript(op[1], word_type, 0);
bld.MUL(result, retype(op[0], dword_type), op[1]); bld.MUL(result, retype(op[0], dword_type), op[1]);
break; break;
} }