OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/perf: don't generate logically dead code

Browse Source 
When divisor is constant integer != 0 there's no point in checking
whether it's 0.

Complained about by Coverity.

Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6126>
This commit is contained in:
Marcin Ślusarz
2020-07-30 15:33:09 +02:00
committed by Marge Bot
parent 0789f4b6d8
commit 289cb6b59a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/intel/perf/gen_perf.py
View File

@@ -105,7 +105,11 @@ def emit_uadd(tmp_id, args):
def emit_udiv(tmp_id, args):
c("uint64_t tmp{0} = {1};".format(tmp_id, args[1]))
c("uint64_t tmp{0} = {1};".format(tmp_id + 1, args[0]))
c("uint64_t tmp{0} = tmp{1} ? tmp{2} / tmp{1} : 0;".format(tmp_id + 2, tmp_id + 1, tmp_id))
if args[0].isdigit():
assert int(args[0]) > 0
c("uint64_t tmp{0} = tmp{2} / tmp{1};".format(tmp_id + 2, tmp_id + 1, tmp_id))
else:
c("uint64_t tmp{0} = tmp{1} ? tmp{2} / tmp{1} : 0;".format(tmp_id + 2, tmp_id + 1, tmp_id))
return tmp_id + 3
def emit_umul(tmp_id, args):