OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: fix some omissions in valhall flow control

Browse Source 
The code for checking flow control did not realize that
`LD_TEX` and `LD_TEX_IMM` were memory accesses, and hence was
not inserting waits where these were necessary. This showed up
as flakes in KHR-GLES31.core.shader_image_load_store.basic-glsl-misc-fs

Cc: mesa-stable
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29363>
This commit is contained in:
Eric R. Smith
2024-05-23 20:26:37 -03:00
committed by Marge Bot
parent de07fd384d
commit 272dcaff01
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/panfrost/compiler/valhall/va_insert_flow.c
View File

@@ -115,9 +115,16 @@ bi_ld_vary_writes_hidden_register(const bi_instr *I)
static bool static bool
bi_is_memory_access(const bi_instr *I) bi_is_memory_access(const bi_instr *I)
{ {
/* On the attribute unit but functionally a general memory load */ /* Some instructions on the attribute unit are functionally
if (I->op == BI_OPCODE_LD_ATTR_TEX) a general memory load */
switch (I->op) {
case BI_OPCODE_LD_ATTR_TEX:
case BI_OPCODE_LD_TEX:
case BI_OPCODE_LD_TEX_IMM:
return true; return true;
default:
break;
}
/* UBOs are read-only so there are no ordering constriants */ /* UBOs are read-only so there are no ordering constriants */
if (I->seg == BI_SEG_UBO) if (I->seg == BI_SEG_UBO)