OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco: fix gfx10_wave64_bpermute

Browse Source 
Since 9254fb4fc7, the pass replaced the SCC clobber with the scalar
identity temporary. Just skip most of the temporary setup, since we don't
need it for gfx10_wave64_bpermute.

Although shuffles are disabled on GFX10, Detroit: Become Human seems to
use them anyway.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-By: Timur Kristóf <timur.kristof@gmail.com>
Fixes: 9254fb4fc7 ('aco: don't use a scalar
       temporary for reductions on GFX10')

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3683>
This commit is contained in:
Rhys Perry
2020-02-03 17:54:07 +00:00
committed by Marge Bot
parent 1c79afd946
commit 20eb1acb6f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/amd/compiler/aco_reduce_assign.cpp
View File

@@ -114,6 +114,11 @@ void setup_reduce_temp(Program* program)
}
}
if (op == gfx10_wave64_bpermute) {
instr->operands[1] = Operand(reduceTmp);
continue;
}
/* same as before, except for the vector temporary instead of the reduce temporary */
unsigned cluster_size = static_cast<Pseudo_reduction_instruction *>(instr)->cluster_size;
bool need_vtmp = op == imul32 || op == fadd64 || op == fmul64 ||
@@ -121,7 +126,7 @@ void setup_reduce_temp(Program* program)
op == umax64 || op == imin64 || op == imax64 ||
op == imul64;
if (program->chip_class >= GFX10 && cluster_size == 64 && op != gfx10_wave64_bpermute)
if (program->chip_class >= GFX10 && cluster_size == 64)
need_vtmp = true;
if (program->chip_class >= GFX10 && op == iadd64)
need_vtmp = true;