radv: Only print "testing use only" message on GFX12+.
This message has been confusing users, especially now that
popular toolkits such as Gtk started using a Vulkan renderer.
Printing a message on non-conformant implementations is also
actually not required. So let's remove it.
We haven't fully finished the GFX12 implementation yet, but on
all other hardware, RADV should work just fine, and is definitely
not meant for "testing use only".
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12314
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
(cherry picked from commit dd980d2b28
)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33113>
This commit is contained in:

committed by
Dylan Baker

parent
6ea2997555
commit
1eb956e7f9
@@ -1454,7 +1454,7 @@
|
||||
"description": "radv: Only print \"testing use only\" message on GFX12+.",
|
||||
"nominated": true,
|
||||
"nomination_type": 1,
|
||||
"resolution": 0,
|
||||
"resolution": 1,
|
||||
"main_sha": null,
|
||||
"because_sha": null,
|
||||
"notes": null
|
||||
|
@@ -168,14 +168,6 @@ radv_get_conformance_version(const struct radv_physical_device *pdev)
|
||||
return conformance_version;
|
||||
}
|
||||
|
||||
static bool
|
||||
radv_is_conformant(const struct radv_physical_device *pdev)
|
||||
{
|
||||
VkConformanceVersion conformance_version = radv_get_conformance_version(pdev);
|
||||
|
||||
return conformance_version.major != 0;
|
||||
}
|
||||
|
||||
static void
|
||||
parse_hex(char *out, const char *in, unsigned length)
|
||||
{
|
||||
@@ -2132,7 +2124,7 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm
|
||||
snprintf(pdev->marketing_name, sizeof(pdev->name), "%s (RADV %s%s)", marketing_name ? marketing_name : "AMD Unknown",
|
||||
pdev->info.name, radv_get_compiler_string(pdev));
|
||||
|
||||
if (!radv_is_conformant(pdev))
|
||||
if (pdev->info.gfx_level >= GFX12)
|
||||
vk_warn_non_conformant_implementation("radv");
|
||||
|
||||
radv_get_driver_uuid(&pdev->driver_uuid);
|
||||
|
Reference in New Issue
Block a user