OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i965: Don't let raw-move check be tricked by immediate vector types

Browse Source 
UB and B type encodings are the same as UV and VF. Noticed when writing
the following patch.

Reviewed-by: Scott D Phillips <scott.d.phillips@intel.com>
This commit is contained in:
Matt Turner
2017-08-01 12:21:54 -07:00
parent 48aa6ecb87
commit 1d79c828d8
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/intel/compiler/brw_eu_validate.c
View File

@@ -96,10 +96,17 @@ inst_is_raw_move(const struct gen_device_info *devinfo, const brw_inst *inst)
unsigned dst_type = signed_type(brw_inst_dst_reg_type(devinfo, inst)); unsigned dst_type = signed_type(brw_inst_dst_reg_type(devinfo, inst));
unsigned src_type = signed_type(brw_inst_src0_reg_type(devinfo, inst)); unsigned src_type = signed_type(brw_inst_src0_reg_type(devinfo, inst));
if (brw_inst_src0_reg_file(devinfo, inst) != BRW_IMMEDIATE_VALUE && if (brw_inst_src0_reg_file(devinfo, inst) == BRW_IMMEDIATE_VALUE) {
(brw_inst_src0_negate(devinfo, inst) || /* FIXME: not strictly true */
brw_inst_src0_abs(devinfo, inst))) if (brw_inst_src0_reg_type(devinfo, inst) == BRW_HW_REG_IMM_TYPE_VF ||
brw_inst_src0_reg_type(devinfo, inst) == BRW_HW_REG_IMM_TYPE_UV ||
brw_inst_src0_reg_type(devinfo, inst) == BRW_HW_REG_IMM_TYPE_V) {
return false;
}
} else if (brw_inst_src0_negate(devinfo, inst) ||
brw_inst_src0_abs(devinfo, inst)) {
return false; return false;
}
return brw_inst_opcode(devinfo, inst) == BRW_OPCODE_MOV && return brw_inst_opcode(devinfo, inst) == BRW_OPCODE_MOV &&
brw_inst_saturate(devinfo, inst) == 0 && brw_inst_saturate(devinfo, inst) == 0 &&