From 1a135bdd6ce39f155e92b881829d642664a5fcfd Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Tue, 20 Sep 2022 10:12:50 +0200 Subject: [PATCH] mesa/st: always use normalized coords for samplers Normalized samplers is the norm, and non-normalized samplers might cause some drivers and hardware to have to bend over backwards a bit. We're using TXF here anyway, so it doesn't really matter what we set this state to. So let's always use normalized samplers instead of always using non-normalized samplers. That makes things easier for everyone. Fixes: 41e093fc98c ("st/pbo: add a fast pbo download code-path") Reviewed-By: Mike Blumenkrantz Part-of: --- src/mesa/state_tracker/st_cb_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 48af25a1df6..8d0b911161b 100644 --- a/src/mesa/state_tracker/st_cb_texture.c +++ b/src/mesa/state_tracker/st_cb_texture.c @@ -1829,6 +1829,7 @@ try_pbo_download(struct st_context *st, struct pipe_sampler_view templ; struct pipe_sampler_view *sampler_view; struct pipe_sampler_state sampler = {0}; + sampler.normalized_coords = true; const struct pipe_sampler_state *samplers[1] = {&sampler}; unsigned level = texImage->TexObject->Attrib.MinLevel + texImage->Level; unsigned max_layer = util_max_layer(texture, level);