Revert "gallium/clover: pass -no-opaque-pointers to Clang", opaque pointers are now implemented

This reverts commit 06e9607478 from !16129.

Clover passed -no-opaque-pointers option to Clang to workaround the fact
the Clover code was not ported to opaque pointers yet.

Opaque pointers are now implemented thanks to !19103 so passing this
option to tell Clang to not do opaque pointers while Clover does
is actually breaking Clover.

Here is an example of what happens when using opaque pointers while
passing -no-opaque-pointers at the same time:

  fatal error: cannot open file 'hawaii-amdgcn-mesa-mesa3d.bc':
   Opaque pointers are only supported in -opaque-pointers mode

This fixes one of the last remaining bits to fully support opaque pointers
in Mesa as referenced in #7468, this is the last remaining bit to fully support
opaque points in Clover.

Signed-off-by: Thomas Debesse <dev@illwieckz.net>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19290>
This commit is contained in:
Thomas Debesse
2022-10-25 05:20:29 +02:00
parent 2a6338722e
commit 1a06dbcaed

View File

@@ -226,13 +226,6 @@ namespace {
// class to recognize it as an OpenCL source file.
#if LLVM_VERSION_MAJOR >= 12
std::vector<const char *> copts;
#if LLVM_VERSION_MAJOR >= 15
// Since LLVM commit 702d5de4 opaque pointers are enabled by default:
// https://gitlab.freedesktop.org/mesa/mesa/-/issues/6342
// A better implementation may be doable following suggestions from there:
// https://github.com/llvm/llvm-project/issues/54970#issuecomment-1102254254
copts.push_back("-no-opaque-pointers");
#endif
for (auto &opt : opts) {
if (opt == "-cl-denorms-are-zero")
copts.push_back("-fdenormal-fp-math=positive-zero");