OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

isl: use 64bit arithmetic to compute size

Browse Source 
If we allow the size to be more than 2^32, then we should compute it
in 64bit arithmetic otherwise we might run into overflow issues.

CID: 1412892, 1412891
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
This commit is contained in:
Lionel Landwerlin
2017-07-13 15:37:43 +01:00
parent 4df93a54f1
commit 19869d6091
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/intel/isl/isl.c
View File

@@ -1469,7 +1469,7 @@ isl_surf_init_s(const struct isl_device *dev,
uint32_t base_alignment; uint32_t base_alignment;
uint64_t size; uint64_t size;
if (tiling == ISL_TILING_LINEAR) { if (tiling == ISL_TILING_LINEAR) {
size = row_pitch * padded_h_el + pad_bytes; size = (uint64_t) row_pitch * padded_h_el + pad_bytes;
/* From the Broadwell PRM Vol 2d, RENDER_SURFACE_STATE::SurfaceBaseAddress: /* From the Broadwell PRM Vol 2d, RENDER_SURFACE_STATE::SurfaceBaseAddress:
* *
@@ -1494,7 +1494,7 @@ isl_surf_init_s(const struct isl_device *dev,
const uint32_t total_h_tl = const uint32_t total_h_tl =
isl_align_div(padded_h_el, tile_info.logical_extent_el.height); isl_align_div(padded_h_el, tile_info.logical_extent_el.height);
size = total_h_tl * tile_info.phys_extent_B.height * row_pitch; size = (uint64_t) total_h_tl * tile_info.phys_extent_B.height * row_pitch;
const uint32_t tile_size = tile_info.phys_extent_B.width * const uint32_t tile_size = tile_info.phys_extent_B.width *
tile_info.phys_extent_B.height; tile_info.phys_extent_B.height;