From 15f18c862f0e84be578554e766d352be10917eb8 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Thu, 19 Sep 2024 09:52:38 +0200 Subject: [PATCH] panvk: Hook up descriptor array bounds checking The clamping on the array index was already implemented, but lower_desc_ctx::add_bounds_checks was always false. Set it based on the robustness state we're being passed. Signed-off-by: Boris Brezillon Reviewed-by: Mary Guillemard Part-of: --- src/panfrost/vulkan/panvk_vX_nir_lower_descriptors.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_vX_nir_lower_descriptors.c b/src/panfrost/vulkan/panvk_vX_nir_lower_descriptors.c index 0eaeba9e80f..f2be7159806 100644 --- a/src/panfrost/vulkan/panvk_vX_nir_lower_descriptors.c +++ b/src/panfrost/vulkan/panvk_vX_nir_lower_descriptors.c @@ -1179,7 +1179,14 @@ panvk_per_arch(nir_lower_descriptors)( struct vk_descriptor_set_layout *const *set_layouts, struct panvk_shader *shader) { - struct lower_desc_ctx ctx = {0}; + struct lower_desc_ctx ctx = { + .add_bounds_checks = + rs->storage_buffers != + VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_DISABLED_EXT || + rs->uniform_buffers != + VK_PIPELINE_ROBUSTNESS_BUFFER_BEHAVIOR_DISABLED_EXT || + rs->images != VK_PIPELINE_ROBUSTNESS_IMAGE_BEHAVIOR_DISABLED_EXT, + }; bool progress; #if PAN_ARCH <= 7