intel/fs: don't forget the stride at generate_shuffle
During generate_shuffle(), when we use byte sized registers we end up with a destination stride of 2. We don't take the stride into consideration when selecting the group offset for the last MOV operation, which means we end up moving things to the wrong place, leaving the last few channels untouched. Take the destination stride in consideration so we don't miss the last channels. v2: Assert this is not necessary for the IVB special case (Jason). Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
This commit is contained in:
@@ -587,12 +587,13 @@ fs_generator::generate_shuffle(fs_inst *inst,
|
||||
struct brw_reg gdst = suboffset(dst, group);
|
||||
struct brw_reg dst_d = retype(spread(gdst, 2),
|
||||
BRW_REGISTER_TYPE_D);
|
||||
assert(dst.hstride == 1);
|
||||
brw_MOV(p, dst_d,
|
||||
retype(brw_VxH_indirect(0, 0), BRW_REGISTER_TYPE_D));
|
||||
brw_MOV(p, byte_offset(dst_d, 4),
|
||||
retype(brw_VxH_indirect(0, 4), BRW_REGISTER_TYPE_D));
|
||||
} else {
|
||||
brw_MOV(p, suboffset(dst, group),
|
||||
brw_MOV(p, suboffset(dst, group * dst.hstride),
|
||||
retype(brw_VxH_indirect(0, 0), src.type));
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user