mesa: Set gl_fragment_program::UsesKill in do_set_program_inouts.
Previously, the code for setting this flag for GLSL programs was duplicated in three places: brw_link_shader(), glsl_to_tgsi_visitor, and ir_to_mesa_visitor. In addition to the unnecessary duplication, there was a performance problem on i965: brw_link_shader() set the flag before doing its final round of optimizations, which meant that if the optimizations managed to eliminate all the discard operations, the flag would still be set, resulting (at least in theory) in slower performance. This patch consolidates all of the code that sets UsesKill for GLSL programs into do_set_program_inouts(), which already is doing a similar job for UsesDFdy, and which occurs after i965's final round of optimizations. Non-GLSL programs (ARB programs and the state tracker's glBitmap program) are unaffected. Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
@@ -2157,8 +2157,6 @@ ir_to_mesa_visitor::visit(ir_return *ir)
|
||||
void
|
||||
ir_to_mesa_visitor::visit(ir_discard *ir)
|
||||
{
|
||||
struct gl_fragment_program *fp = (struct gl_fragment_program *)this->prog;
|
||||
|
||||
if (ir->condition) {
|
||||
ir->condition->accept(this);
|
||||
this->result.negate = ~this->result.negate;
|
||||
@@ -2166,8 +2164,6 @@ ir_to_mesa_visitor::visit(ir_discard *ir)
|
||||
} else {
|
||||
emit(ir, OPCODE_KIL_NV);
|
||||
}
|
||||
|
||||
fp->UsesKill = GL_TRUE;
|
||||
}
|
||||
|
||||
void
|
||||
|
Reference in New Issue
Block a user