OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: remove unneeded soft renderbuffer format-setting code

Browse Source 
These vars will just get overwritten when we call _mesa_add_renderbuffer()
anyway.  We only need to set the InternalFormat field when we create the
software renderbuffer.

Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Brian Paul
2011-11-05 12:54:06 -06:00
parent 87ac3ae50e
commit 0ef8c0ddc7
1 changed files with 0 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/mesa/main/renderbuffer.c
View File

@@ -2127,16 +2127,6 @@ _mesa_add_color_renderbuffers(struct gl_context *ctx, struct gl_framebuffer *fb,
return GL_FALSE; return GL_FALSE;
} }
if (rgbBits <= 8) {
if (alphaBits)
rb->Format = MESA_FORMAT_RGBA8888;
else
rb->Format = MESA_FORMAT_RGB888;
}
else {
assert(rgbBits <= 16);
rb->Format = MESA_FORMAT_NONE; /*XXX RGBA16;*/
}
rb->InternalFormat = GL_RGBA; rb->InternalFormat = GL_RGBA;
rb->AllocStorage = _mesa_soft_renderbuffer_storage; rb->AllocStorage = _mesa_soft_renderbuffer_storage;
@@ -2284,15 +2274,12 @@ _mesa_add_depth_renderbuffer(struct gl_context *ctx, struct gl_framebuffer *fb,
} }
if (depthBits <= 16) { if (depthBits <= 16) {
rb->Format = MESA_FORMAT_Z16;
rb->InternalFormat = GL_DEPTH_COMPONENT16; rb->InternalFormat = GL_DEPTH_COMPONENT16;
} }
else if (depthBits <= 24) { else if (depthBits <= 24) {
rb->Format = MESA_FORMAT_X8_Z24;
rb->InternalFormat = GL_DEPTH_COMPONENT24; rb->InternalFormat = GL_DEPTH_COMPONENT24;
} }
else { else {
rb->Format = MESA_FORMAT_Z32;
rb->InternalFormat = GL_DEPTH_COMPONENT32; rb->InternalFormat = GL_DEPTH_COMPONENT32;
} }
@@ -2332,7 +2319,6 @@ _mesa_add_stencil_renderbuffer(struct gl_context *ctx, struct gl_framebuffer *fb
} }
assert(stencilBits <= 8); assert(stencilBits <= 8);
rb->Format = MESA_FORMAT_S8;
rb->InternalFormat = GL_STENCIL_INDEX8; rb->InternalFormat = GL_STENCIL_INDEX8;
rb->AllocStorage = _mesa_soft_renderbuffer_storage; rb->AllocStorage = _mesa_soft_renderbuffer_storage;
@@ -2371,7 +2357,6 @@ _mesa_add_accum_renderbuffer(struct gl_context *ctx, struct gl_framebuffer *fb,
return GL_FALSE; return GL_FALSE;
} }
rb->Format = MESA_FORMAT_SIGNED_RGBA_16;
rb->InternalFormat = GL_RGBA16_SNORM; rb->InternalFormat = GL_RGBA16_SNORM;
rb->AllocStorage = _mesa_soft_renderbuffer_storage; rb->AllocStorage = _mesa_soft_renderbuffer_storage;
_mesa_add_renderbuffer(fb, BUFFER_ACCUM, rb); _mesa_add_renderbuffer(fb, BUFFER_ACCUM, rb);
@@ -2416,7 +2401,6 @@ _mesa_add_aux_renderbuffers(struct gl_context *ctx, struct gl_framebuffer *fb,
} }
assert (colorBits <= 8); assert (colorBits <= 8);
rb->Format = MESA_FORMAT_RGBA8888;
rb->InternalFormat = GL_RGBA; rb->InternalFormat = GL_RGBA;
rb->AllocStorage = _mesa_soft_renderbuffer_storage; rb->AllocStorage = _mesa_soft_renderbuffer_storage;