ac/surface: finish display DCC for gfx12

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30114>
This commit is contained in:
Marek Olšák
2024-07-10 17:14:11 -04:00
committed by Marge Bot
parent 46071c90c7
commit 0bb83a4060

View File

@@ -1791,11 +1791,10 @@ void ac_modifier_max_extent(const struct radeon_info *info,
/* DCC is supported with any size. The maximum width per display pipe is 5760, but multiple
* display pipes can be used to drive the display.
*/
// TODO: Gfx12
*width = 16384;
*height = 16384;
if (ac_modifier_has_dcc(modifier)) {
if (info->gfx_level < GFX12 && ac_modifier_has_dcc(modifier)) {
bool independent_64B_blocks = AMD_FMT_MOD_GET(DCC_INDEPENDENT_64B, modifier);
if (info->gfx_level >= GFX10 && !independent_64B_blocks) {
@@ -3238,6 +3237,7 @@ static bool gfx12_compute_surface(struct ac_addrlib *addrlib, const struct radeo
surf->u.gfx9.uses_custom_pitch = true;
}
bool supports_display_dcc = info->drm_minor >= 59;
surf->u.gfx9.swizzle_mode = AddrSurfInfoIn.swizzleMode;
surf->u.gfx9.resource_type = (enum gfx9_resource_type)AddrSurfInfoIn.resourceType;
surf->u.gfx9.gfx12_enable_dcc = ac_modifier_has_dcc(surf->modifier) ||
@@ -3246,9 +3246,8 @@ static bool gfx12_compute_surface(struct ac_addrlib *addrlib, const struct radeo
/* Always enable compression for Z/S and MSAA color by default. */
(surf->flags & RADEON_SURF_Z_OR_SBUFFER ||
config->info.samples > 1 ||
/* TODO: enable display DCC after DAL is ready */
(!(surf->flags & RADEON_SURF_SCANOUT) &&
/* These two are not strictly necessary. */
((supports_display_dcc || !(surf->flags & RADEON_SURF_SCANOUT)) &&
/* These two are not strictly necessary. */
surf->u.gfx9.swizzle_mode != ADDR3_LINEAR &&
surf->surf_size >= 4096)));
@@ -3256,8 +3255,7 @@ static bool gfx12_compute_surface(struct ac_addrlib *addrlib, const struct radeo
surf->is_linear = surf->u.gfx9.swizzle_mode == ADDR3_LINEAR;
surf->is_displayable = !(surf->flags & RADEON_SURF_Z_OR_SBUFFER) &&
surf->u.gfx9.resource_type != RADEON_RESOURCE_3D &&
/* TODO: enable display DCC after DAL is ready */
!surf->u.gfx9.gfx12_enable_dcc;
(supports_display_dcc || !surf->u.gfx9.gfx12_enable_dcc);
surf->thick_tiling = surf->u.gfx9.swizzle_mode >= ADDR3_4KB_3D;
if (surf->flags & RADEON_SURF_Z_OR_SBUFFER) {
@@ -3274,7 +3272,6 @@ static bool gfx12_compute_surface(struct ac_addrlib *addrlib, const struct radeo
} else if (!(surf->flags & RADEON_SURF_Z_OR_SBUFFER) &&
/* Don't change the DCC settings for imported buffers - they might differ. */
!(surf->flags & RADEON_SURF_IMPORTED)) {
/* TODO: decide what to set for scanout buffers after DAL is ready */
surf->u.gfx9.color.dcc.max_compressed_block_size = V_028C78_MAX_BLOCK_SIZE_128B;
}
}