nir/large_constants: Eliminate out-of-bounds writes to large constants
Out-of-bounds writes could be eliminated per spec:
Section 5.11 (Out-of-Bounds Accesses) of the GLSL 4.60 spec says:
"In the subsections described above for array, vector, matrix and
structure accesses, any out-of-bounds access produced undefined
behavior.... Out-of-bounds writes may be discarded or overwrite
other variables of the active program."
Fixes: 1235850522
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6428>
This commit is contained in:

committed by
Marge Bot

parent
66669eb529
commit
0ba82f78a5
@@ -118,8 +118,11 @@ handle_constant_store(void *mem_ctx, struct var_info *info,
|
||||
info->constant_data = rzalloc_size(mem_ctx, var_size);
|
||||
}
|
||||
|
||||
char *dst = (char *)info->constant_data +
|
||||
nir_deref_instr_get_const_offset(deref, size_align);
|
||||
const unsigned offset = nir_deref_instr_get_const_offset(deref, size_align);
|
||||
if (offset >= info->constant_data_size)
|
||||
return;
|
||||
|
||||
char *dst = (char *)info->constant_data + offset;
|
||||
|
||||
for (unsigned i = 0; i < num_components; i++) {
|
||||
if (!(writemask & (1 << i)))
|
||||
|
Reference in New Issue
Block a user