OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadcom/compiler: remove v3d_fs_key depth_enabled field.

Browse Source 
It is not used right now, so keeping it adds some noise/confusion.

So far configuring Z test are done through the CFG_BITS. See
v3dX(emit_state) at v3dx_emit.c for v3d, and pack_cfg_bits at
v3dv_pipeline.c for v3dv. There flags like z_updates_enable and others
are filled up.

That key field seems like a leftover coming from using vc4 as
reference, as that driver defines and uses a field with name name.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7421>
This commit is contained in:
Alejandro Piñeiro
2020-11-02 23:37:54 +01:00
committed by Marge Bot
parent 21ffacff8c
commit 09b2bd1df9
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/broadcom/compiler/v3d_compiler.h
View File

@@ -360,7 +360,6 @@ struct v3d_key {
struct v3d_fs_key {
struct v3d_key base;
bool depth_enabled;
bool is_points;
bool is_lines;
bool line_smoothing;

5
src/broadcom/vulkan/v3dv_pipeline.c
View File

@@ -1145,11 +1145,6 @@ pipeline_populate_v3d_fs_key(struct v3d_fs_key *key,
}
}
const VkPipelineDepthStencilStateCreateInfo *ds_info =
pCreateInfo->pDepthStencilState;
key->depth_enabled = (ds_info == NULL ? false : ds_info->depthTestEnable);
/* Vulkan doesn't support alpha test */
key->alpha_test = false;
key->alpha_test_func = COMPARE_FUNC_NEVER;

2
src/gallium/drivers/v3d/v3d_program.c
View File

@@ -559,8 +559,6 @@ v3d_update_compiled_fs(struct v3d_context *v3d, uint8_t prim_mode)
key->sample_alpha_to_one = v3d->blend->base.alpha_to_one;
}
key->depth_enabled = (v3d->zsa->base.depth.enabled ||
v3d->zsa->base.stencil[0].enabled);
if (v3d->zsa->base.alpha.enabled) {
key->alpha_test = true;
key->alpha_test_func = v3d->zsa->base.alpha.func;