From 056280a4a162bf4e43c2d4439dccaeb818e8698a Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sun, 25 Sep 2022 20:02:48 -0400 Subject: [PATCH] agx: Implement scalar load/store_preamble These need to copy values between GPRs and uniform registers. This is pretty easy in either direction. This implements scalar versions of the intrinsics. A backend NIR pass will scalarize for us. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/compiler/agx_compile.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/asahi/compiler/agx_compile.c b/src/asahi/compiler/agx_compile.c index 8c1fdd4bf1b..65d7af0879c 100644 --- a/src/asahi/compiler/agx_compile.c +++ b/src/asahi/compiler/agx_compile.c @@ -584,6 +584,24 @@ agx_emit_load_ubo(agx_builder *b, agx_index dst, nir_intrinsic_instr *instr) return NULL; } +/* Preambles write directly to uniform registers, so move from uniform to GPR */ +static agx_instr * +agx_emit_load_preamble(agx_builder *b, agx_index dst, nir_intrinsic_instr *instr) +{ + assert(nir_dest_num_components(instr->dest) == 1 && "already scalarized"); + return agx_mov_to(b, dst, agx_uniform(nir_intrinsic_base(instr), dst.size)); +} + +static agx_instr * +agx_emit_store_preamble(agx_builder *b, nir_intrinsic_instr *instr) +{ + assert(nir_src_num_components(instr->src[0]) == 1 && "already scalarized"); + + agx_index value = agx_src_index(&instr->src[0]); + agx_index offset = agx_immediate(nir_intrinsic_base(instr)); + return agx_uniform_store(b, value, offset); +} + /* * Emit code to generate gl_FragCoord. The xy components are calculated from * special registers, whereas the zw components are interpolated varyings. @@ -712,6 +730,12 @@ agx_emit_intrinsic(agx_builder *b, nir_intrinsic_instr *instr) case nir_intrinsic_load_instance_id: return agx_mov_to(b, dst, agx_abs(agx_instance_id(b))); + case nir_intrinsic_load_preamble: + return agx_emit_load_preamble(b, dst, instr); + + case nir_intrinsic_store_preamble: + return agx_emit_store_preamble(b, instr); + case nir_intrinsic_load_blend_const_color_r_float: return agx_blend_const(b, dst, 0); case nir_intrinsic_load_blend_const_color_g_float: return agx_blend_const(b, dst, 1); case nir_intrinsic_load_blend_const_color_b_float: return agx_blend_const(b, dst, 2);