From 02efe52aab6b544b57c29c9f4345de1a4a64bcb7 Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Tue, 14 May 2024 12:47:16 +0200 Subject: [PATCH] panvk: Only clear UBOs descriptors when set isn't present The layout for dyn UBOs changed but we were still cleaning right after UBOs. Signed-off-by: Mary Guillemard Reviewed-by: Boris Brezillon Fixes: 9c553bda9c18 ("panvk: Prepare dynamic buffer descriptors at bind time") Part-of: --- src/panfrost/vulkan/panvk_vX_cmd_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panfrost/vulkan/panvk_vX_cmd_buffer.c b/src/panfrost/vulkan/panvk_vX_cmd_buffer.c index 58cdfa23cf0..ba4a7590408 100644 --- a/src/panfrost/vulkan/panvk_vX_cmd_buffer.c +++ b/src/panfrost/vulkan/panvk_vX_cmd_buffer.c @@ -433,8 +433,8 @@ panvk_cmd_prepare_ubos(struct panvk_cmd_buffer *cmdbuf, panvk_per_arch(pipeline_layout_ubo_start)(pipeline->layout, s, false); if (!set) { - unsigned all_ubos = set_layout->num_ubos + set_layout->num_dyn_ubos; - memset(&ubo_descs[ubo_start], 0, all_ubos * sizeof(*ubo_descs)); + memset(&ubo_descs[ubo_start], 0, + set_layout->num_ubos * sizeof(*ubo_descs)); } else { memcpy(&ubo_descs[ubo_start], set->ubos, set_layout->num_ubos * sizeof(*ubo_descs));