OpenHarmony/third_party_mesa3d
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

llvmpipe: make sure to initialize the lp_setup_context slots with the default values

Browse Source 
As 0 is an actual valid value, this can lead to issues when we actually want to use them.

This fixes `spec@arb_cull_distance@basic-cull-3` crashes for instance.

Cc: mesa-stable

Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25152>
This commit is contained in:
Corentin Noël
2023-09-11 16:53:03 +02:00
committed by Marge Bot
parent f9b341cbf4
commit 010147cd64
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/gallium/drivers/llvmpipe/ci/llvmpipe-fails.txt
View File

@@ -198,6 +198,3 @@ spec@intel_shader_atomic_float_minmax@execution@ssbo-atomiccompswap-float-nan,Cr
spec@intel_shader_atomic_float_minmax@execution@ssbo-atomiccompswap-float-negative-zero,Crash
spec@!opengl 1.1@line-flat-clip-color,Fail
spec@intel_shader_atomic_float_minmax@execution@shared-atomiccompswap-float,Crash
spec@arb_cull_distance@basic-cull-3,Crash
spec@arb_cull_distance@basic-cull-4,Crash
spec@arb_cull_distance@vs-cull-distance-vertex-outside-cull-volume,Crash

5
src/gallium/drivers/llvmpipe/lp_setup.c
View File

@@ -1336,6 +1336,11 @@ lp_setup_create(struct pipe_context *pipe,
lp_setup_init_vbuf(setup);
setup->psize_slot = -1;
setup->viewport_index_slot = -1;
setup->layer_slot = -1;
setup->face_slot = -1;
/* Used only in update_state():
*/
setup->pipe = pipe;

3
src/gallium/drivers/virgl/ci/virpipe-gl-fails.txt
View File

@@ -678,6 +678,3 @@ spec@arb_viewport_array@display-list,Fail
spec@arb_gl_spirv@execution@ssbo@unsized-array,Fail
spec@arb_pipeline_statistics_query@arb_pipeline_statistics_query-frag,Fail
spec@!opengl 1.1@line-flat-clip-color,Fail
spec@arb_cull_distance@basic-cull-3,Crash
spec@arb_cull_distance@basic-cull-4,Crash
spec@arb_cull_distance@vs-cull-distance-vertex-outside-cull-volume,Crash