2010-06-22 12:07:21 -07:00
|
|
|
/*
|
|
|
|
* Copyright © 2010 Intel Corporation
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
* Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
|
|
* DEALINGS IN THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* \file ir_validate.cpp
|
|
|
|
*
|
|
|
|
* Attempts to verify that various invariants of the IR tree are true.
|
|
|
|
*
|
|
|
|
* In particular, at the moment it makes sure that no single
|
|
|
|
* ir_instruction node except for ir_variable appears multiple times
|
|
|
|
* in the ir tree. ir_variable does appear multiple times: Once as a
|
|
|
|
* declaration in an exec_list, and multiple times as the endpoint of
|
|
|
|
* a dereference chain.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include "ir.h"
|
2010-06-22 18:41:50 -07:00
|
|
|
#include "ir_hierarchical_visitor.h"
|
2010-07-29 12:40:49 +03:00
|
|
|
#include "program/hash_table.h"
|
2010-07-20 17:18:57 -07:00
|
|
|
#include "glsl_types.h"
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
class ir_validate : public ir_hierarchical_visitor {
|
|
|
|
public:
|
|
|
|
ir_validate()
|
|
|
|
{
|
2010-07-06 14:49:14 -07:00
|
|
|
this->ht = hash_table_ctor(0, hash_table_pointer_hash,
|
|
|
|
hash_table_pointer_compare);
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-07-02 13:30:23 -07:00
|
|
|
this->current_function = NULL;
|
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
this->callback = ir_validate::validate_ir;
|
|
|
|
this->data = ht;
|
|
|
|
}
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
~ir_validate()
|
|
|
|
{
|
|
|
|
hash_table_dtor(this->ht);
|
|
|
|
}
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
virtual ir_visitor_status visit(ir_variable *v);
|
2010-07-12 13:55:32 -07:00
|
|
|
virtual ir_visitor_status visit(ir_dereference_variable *ir);
|
2011-08-18 13:52:28 -07:00
|
|
|
|
|
|
|
virtual ir_visitor_status visit_enter(ir_if *ir);
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-08-26 15:22:06 -07:00
|
|
|
virtual ir_visitor_status visit_leave(ir_loop *ir);
|
2010-07-02 13:30:23 -07:00
|
|
|
virtual ir_visitor_status visit_enter(ir_function *ir);
|
|
|
|
virtual ir_visitor_status visit_leave(ir_function *ir);
|
|
|
|
virtual ir_visitor_status visit_enter(ir_function_signature *ir);
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
virtual ir_visitor_status visit_leave(ir_expression *ir);
|
2010-09-27 15:48:15 -07:00
|
|
|
virtual ir_visitor_status visit_leave(ir_swizzle *ir);
|
2010-07-27 09:01:30 -07:00
|
|
|
|
2010-08-04 16:27:17 -07:00
|
|
|
virtual ir_visitor_status visit_enter(ir_assignment *ir);
|
2011-03-07 15:13:06 -08:00
|
|
|
virtual ir_visitor_status visit_enter(ir_call *ir);
|
2010-08-04 16:27:17 -07:00
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
static void validate_ir(ir_instruction *ir, void *data);
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-07-02 13:30:23 -07:00
|
|
|
ir_function *current_function;
|
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
struct hash_table *ht;
|
|
|
|
};
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-07-12 13:55:32 -07:00
|
|
|
|
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit(ir_dereference_variable *ir)
|
|
|
|
{
|
|
|
|
if ((ir->var == NULL) || (ir->var->as_variable() == NULL)) {
|
|
|
|
printf("ir_dereference_variable @ %p does not specify a variable %p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
(void *) ir, (void *) ir->var);
|
2010-07-12 13:55:32 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (hash_table_find(ht, ir->var) == NULL) {
|
|
|
|
printf("ir_dereference_variable @ %p specifies undeclared variable "
|
|
|
|
"`%s' @ %p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
(void *) ir, ir->var->name, (void *) ir->var);
|
2010-07-12 13:55:32 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2010-07-12 15:46:16 -07:00
|
|
|
this->validate_ir(ir, this->data);
|
|
|
|
|
2010-07-12 13:55:32 -07:00
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2010-07-22 16:24:49 -07:00
|
|
|
ir_visitor_status
|
2011-08-18 13:52:28 -07:00
|
|
|
ir_validate::visit_enter(ir_if *ir)
|
2010-07-22 16:24:49 -07:00
|
|
|
{
|
|
|
|
if (ir->condition->type != glsl_type::bool_type) {
|
|
|
|
printf("ir_if condition %s type instead of bool.\n",
|
|
|
|
ir->condition->type->name);
|
|
|
|
ir->print();
|
|
|
|
printf("\n");
|
|
|
|
abort();
|
|
|
|
}
|
2010-07-27 00:18:33 -07:00
|
|
|
|
|
|
|
return visit_continue;
|
2010-07-22 16:24:49 -07:00
|
|
|
}
|
|
|
|
|
2010-07-12 13:55:32 -07:00
|
|
|
|
2010-08-26 15:22:06 -07:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_leave(ir_loop *ir)
|
|
|
|
{
|
|
|
|
if (ir->counter != NULL) {
|
2012-11-30 18:33:21 +10:00
|
|
|
if ((ir->from == NULL) || (ir->to == NULL) || (ir->increment == NULL)) {
|
2010-08-26 15:22:06 -07:00
|
|
|
printf("ir_loop has invalid loop controls:\n"
|
|
|
|
" counter: %p\n"
|
|
|
|
" from: %p\n"
|
|
|
|
" to: %p\n"
|
|
|
|
" increment: %p\n",
|
2010-09-20 08:22:51 -06:00
|
|
|
(void *) ir->counter, (void *) ir->from, (void *) ir->to,
|
|
|
|
(void *) ir->increment);
|
2010-08-26 15:22:06 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
|
|
|
if ((ir->cmp < ir_binop_less) || (ir->cmp > ir_binop_nequal)) {
|
|
|
|
printf("ir_loop has invalid comparitor %d\n", ir->cmp);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
} else {
|
2012-11-30 18:33:21 +10:00
|
|
|
if ((ir->from != NULL) || (ir->to != NULL) || (ir->increment != NULL)) {
|
2010-08-26 15:22:06 -07:00
|
|
|
printf("ir_loop has invalid loop controls:\n"
|
|
|
|
" counter: %p\n"
|
|
|
|
" from: %p\n"
|
|
|
|
" to: %p\n"
|
|
|
|
" increment: %p\n",
|
2010-09-20 08:22:51 -06:00
|
|
|
(void *) ir->counter, (void *) ir->from, (void *) ir->to,
|
|
|
|
(void *) ir->increment);
|
2010-08-26 15:22:06 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2010-07-02 13:30:23 -07:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_enter(ir_function *ir)
|
|
|
|
{
|
|
|
|
/* Function definitions cannot be nested.
|
|
|
|
*/
|
|
|
|
if (this->current_function != NULL) {
|
|
|
|
printf("Function definition nested inside another function "
|
|
|
|
"definition:\n");
|
|
|
|
printf("%s %p inside %s %p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
ir->name, (void *) ir,
|
|
|
|
this->current_function->name, (void *) this->current_function);
|
2010-07-02 13:30:23 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Store the current function hierarchy being traversed. This is used
|
|
|
|
* by the function signature visitor to ensure that the signatures are
|
|
|
|
* linked with the correct functions.
|
|
|
|
*/
|
|
|
|
this->current_function = ir;
|
|
|
|
|
|
|
|
this->validate_ir(ir, this->data);
|
|
|
|
|
2011-03-07 15:13:06 -08:00
|
|
|
/* Verify that all of the things stored in the list of signatures are,
|
|
|
|
* in fact, function signatures.
|
|
|
|
*/
|
|
|
|
foreach_list(node, &ir->signatures) {
|
|
|
|
ir_instruction *sig = (ir_instruction *) node;
|
|
|
|
|
|
|
|
if (sig->ir_type != ir_type_function_signature) {
|
|
|
|
printf("Non-signature in signature list of function `%s'\n",
|
|
|
|
ir->name);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-07-02 13:30:23 -07:00
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_leave(ir_function *ir)
|
|
|
|
{
|
2011-01-21 14:32:31 -08:00
|
|
|
assert(ralloc_parent(ir->name) == ir);
|
2010-07-02 13:30:23 -07:00
|
|
|
|
|
|
|
this->current_function = NULL;
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_enter(ir_function_signature *ir)
|
|
|
|
{
|
|
|
|
if (this->current_function != ir->function()) {
|
|
|
|
printf("Function signature nested inside wrong function "
|
|
|
|
"definition:\n");
|
|
|
|
printf("%p inside %s %p instead of %s %p\n",
|
2010-08-11 14:04:51 -06:00
|
|
|
(void *) ir,
|
|
|
|
this->current_function->name, (void *) this->current_function,
|
|
|
|
ir->function_name(), (void *) ir->function());
|
2010-07-02 13:30:23 -07:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2011-03-07 15:08:22 -08:00
|
|
|
if (ir->return_type == NULL) {
|
|
|
|
printf("Function signature %p for function %s has NULL return type.\n",
|
2011-03-10 09:29:00 -07:00
|
|
|
(void *) ir, ir->function_name());
|
2011-03-07 15:08:22 -08:00
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2010-07-02 13:30:23 -07:00
|
|
|
this->validate_ir(ir, this->data);
|
|
|
|
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_leave(ir_expression *ir)
|
|
|
|
{
|
|
|
|
switch (ir->operation) {
|
|
|
|
case ir_unop_bit_not:
|
|
|
|
assert(ir->operands[0]->type == ir->type);
|
|
|
|
break;
|
|
|
|
case ir_unop_logic_not:
|
2010-08-02 12:06:34 -07:00
|
|
|
assert(ir->type->base_type == GLSL_TYPE_BOOL);
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
|
2010-07-27 09:01:30 -07:00
|
|
|
break;
|
|
|
|
|
|
|
|
case ir_unop_neg:
|
|
|
|
case ir_unop_abs:
|
|
|
|
case ir_unop_sign:
|
|
|
|
case ir_unop_rcp:
|
|
|
|
case ir_unop_rsq:
|
|
|
|
case ir_unop_sqrt:
|
2010-08-05 15:22:05 -07:00
|
|
|
assert(ir->type == ir->operands[0]->type);
|
|
|
|
break;
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_unop_exp:
|
|
|
|
case ir_unop_log:
|
|
|
|
case ir_unop_exp2:
|
|
|
|
case ir_unop_log2:
|
2010-08-05 15:22:05 -07:00
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
2010-07-27 09:01:30 -07:00
|
|
|
assert(ir->type == ir->operands[0]->type);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ir_unop_f2i:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
2011-06-14 12:40:09 -07:00
|
|
|
assert(ir->type->base_type == GLSL_TYPE_INT);
|
2010-07-27 09:01:30 -07:00
|
|
|
break;
|
2012-06-13 15:47:45 -07:00
|
|
|
case ir_unop_f2u:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
break;
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_unop_i2f:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
break;
|
|
|
|
case ir_unop_f2b:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_BOOL);
|
|
|
|
break;
|
|
|
|
case ir_unop_b2f:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
break;
|
|
|
|
case ir_unop_i2b:
|
2011-06-14 12:40:09 -07:00
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
|
2010-07-27 09:01:30 -07:00
|
|
|
assert(ir->type->base_type == GLSL_TYPE_BOOL);
|
|
|
|
break;
|
|
|
|
case ir_unop_b2i:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
|
2011-06-14 12:40:09 -07:00
|
|
|
assert(ir->type->base_type == GLSL_TYPE_INT);
|
2010-07-27 09:01:30 -07:00
|
|
|
break;
|
|
|
|
case ir_unop_u2f:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
break;
|
2011-06-14 23:34:11 -07:00
|
|
|
case ir_unop_i2u:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
break;
|
|
|
|
case ir_unop_u2i:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_INT);
|
|
|
|
break;
|
2012-05-08 20:40:34 +02:00
|
|
|
case ir_unop_bitcast_i2f:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_INT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
break;
|
|
|
|
case ir_unop_bitcast_f2i:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_INT);
|
|
|
|
break;
|
|
|
|
case ir_unop_bitcast_u2f:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
break;
|
|
|
|
case ir_unop_bitcast_f2u:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->type->base_type == GLSL_TYPE_UINT);
|
|
|
|
break;
|
2010-07-27 09:01:30 -07:00
|
|
|
|
2010-08-23 12:21:33 -07:00
|
|
|
case ir_unop_any:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_BOOL);
|
|
|
|
assert(ir->type == glsl_type::bool_type);
|
|
|
|
break;
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_unop_trunc:
|
2010-10-15 15:44:01 -06:00
|
|
|
case ir_unop_round_even:
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_unop_ceil:
|
|
|
|
case ir_unop_floor:
|
|
|
|
case ir_unop_fract:
|
|
|
|
case ir_unop_sin:
|
|
|
|
case ir_unop_cos:
|
2010-11-18 11:05:32 -08:00
|
|
|
case ir_unop_sin_reduced:
|
|
|
|
case ir_unop_cos_reduced:
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_unop_dFdx:
|
|
|
|
case ir_unop_dFdy:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->operands[0]->type == ir->type);
|
|
|
|
break;
|
|
|
|
|
2012-11-19 10:48:25 -08:00
|
|
|
case ir_unop_pack_snorm_2x16:
|
|
|
|
case ir_unop_pack_unorm_2x16:
|
|
|
|
case ir_unop_pack_half_2x16:
|
|
|
|
assert(ir->type == glsl_type::uint_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::vec2_type);
|
|
|
|
break;
|
|
|
|
|
2013-01-21 14:12:37 -08:00
|
|
|
case ir_unop_pack_snorm_4x8:
|
|
|
|
case ir_unop_pack_unorm_4x8:
|
|
|
|
assert(ir->type == glsl_type::uint_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::vec4_type);
|
|
|
|
break;
|
|
|
|
|
2012-11-19 10:48:25 -08:00
|
|
|
case ir_unop_unpack_snorm_2x16:
|
|
|
|
case ir_unop_unpack_unorm_2x16:
|
|
|
|
case ir_unop_unpack_half_2x16:
|
|
|
|
assert(ir->type == glsl_type::vec2_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::uint_type);
|
|
|
|
break;
|
|
|
|
|
2013-01-21 14:12:37 -08:00
|
|
|
case ir_unop_unpack_snorm_4x8:
|
|
|
|
case ir_unop_unpack_unorm_4x8:
|
|
|
|
assert(ir->type == glsl_type::vec4_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::uint_type);
|
|
|
|
break;
|
|
|
|
|
2012-11-19 10:48:25 -08:00
|
|
|
case ir_unop_unpack_half_2x16_split_x:
|
|
|
|
case ir_unop_unpack_half_2x16_split_y:
|
|
|
|
assert(ir->type == glsl_type::float_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::uint_type);
|
|
|
|
break;
|
|
|
|
|
2010-09-14 09:15:19 -06:00
|
|
|
case ir_unop_noise:
|
|
|
|
/* XXX what can we assert here? */
|
|
|
|
break;
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_binop_add:
|
|
|
|
case ir_binop_sub:
|
|
|
|
case ir_binop_mul:
|
|
|
|
case ir_binop_div:
|
|
|
|
case ir_binop_mod:
|
|
|
|
case ir_binop_min:
|
|
|
|
case ir_binop_max:
|
|
|
|
case ir_binop_pow:
|
|
|
|
if (ir->operands[0]->type->is_scalar())
|
|
|
|
assert(ir->operands[1]->type == ir->type);
|
|
|
|
else if (ir->operands[1]->type->is_scalar())
|
|
|
|
assert(ir->operands[0]->type == ir->type);
|
|
|
|
else if (ir->operands[0]->type->is_vector() &&
|
|
|
|
ir->operands[1]->type->is_vector()) {
|
|
|
|
assert(ir->operands[0]->type == ir->operands[1]->type);
|
|
|
|
assert(ir->operands[0]->type == ir->type);
|
|
|
|
}
|
|
|
|
break;
|
2010-09-08 01:31:39 +02:00
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_binop_less:
|
|
|
|
case ir_binop_greater:
|
|
|
|
case ir_binop_lequal:
|
|
|
|
case ir_binop_gequal:
|
2010-09-08 01:31:39 +02:00
|
|
|
case ir_binop_equal:
|
|
|
|
case ir_binop_nequal:
|
|
|
|
/* The semantics of the IR operators differ from the GLSL <, >, <=, >=,
|
|
|
|
* ==, and != operators. The IR operators perform a component-wise
|
|
|
|
* comparison on scalar or vector types and return a boolean scalar or
|
|
|
|
* vector type of the same size.
|
2010-07-27 09:01:30 -07:00
|
|
|
*/
|
2010-09-08 01:31:39 +02:00
|
|
|
assert(ir->type->base_type == GLSL_TYPE_BOOL);
|
2010-07-27 09:01:30 -07:00
|
|
|
assert(ir->operands[0]->type == ir->operands[1]->type);
|
2010-09-08 01:31:39 +02:00
|
|
|
assert(ir->operands[0]->type->is_vector()
|
|
|
|
|| ir->operands[0]->type->is_scalar());
|
|
|
|
assert(ir->operands[0]->type->vector_elements
|
|
|
|
== ir->type->vector_elements);
|
2010-07-27 09:01:30 -07:00
|
|
|
break;
|
|
|
|
|
2010-09-08 01:31:39 +02:00
|
|
|
case ir_binop_all_equal:
|
|
|
|
case ir_binop_any_nequal:
|
|
|
|
/* GLSL == and != operate on scalars, vectors, matrices and arrays, and
|
|
|
|
* return a scalar boolean. The IR matches that.
|
2010-07-27 09:01:30 -07:00
|
|
|
*/
|
|
|
|
assert(ir->type == glsl_type::bool_type);
|
|
|
|
assert(ir->operands[0]->type == ir->operands[1]->type);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ir_binop_lshift:
|
|
|
|
case ir_binop_rshift:
|
2010-10-08 16:22:28 -07:00
|
|
|
assert(ir->operands[0]->type->is_integer() &&
|
|
|
|
ir->operands[1]->type->is_integer());
|
|
|
|
if (ir->operands[0]->type->is_scalar()) {
|
|
|
|
assert(ir->operands[1]->type->is_scalar());
|
|
|
|
}
|
|
|
|
if (ir->operands[0]->type->is_vector() &&
|
|
|
|
ir->operands[1]->type->is_vector()) {
|
|
|
|
assert(ir->operands[0]->type->components() ==
|
|
|
|
ir->operands[1]->type->components());
|
|
|
|
}
|
|
|
|
assert(ir->type == ir->operands[0]->type);
|
|
|
|
break;
|
|
|
|
|
2010-07-27 09:01:30 -07:00
|
|
|
case ir_binop_bit_and:
|
|
|
|
case ir_binop_bit_xor:
|
|
|
|
case ir_binop_bit_or:
|
2010-10-13 08:29:58 -07:00
|
|
|
assert(ir->operands[0]->type->base_type ==
|
|
|
|
ir->operands[1]->type->base_type);
|
|
|
|
assert(ir->type->is_integer());
|
|
|
|
if (ir->operands[0]->type->is_vector() &&
|
|
|
|
ir->operands[1]->type->is_vector()) {
|
|
|
|
assert(ir->operands[0]->type->vector_elements ==
|
|
|
|
ir->operands[1]->type->vector_elements);
|
|
|
|
}
|
|
|
|
break;
|
2010-07-27 09:01:30 -07:00
|
|
|
|
|
|
|
case ir_binop_logic_and:
|
|
|
|
case ir_binop_logic_xor:
|
|
|
|
case ir_binop_logic_or:
|
|
|
|
assert(ir->type == glsl_type::bool_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::bool_type);
|
|
|
|
assert(ir->operands[1]->type == glsl_type::bool_type);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case ir_binop_dot:
|
|
|
|
assert(ir->type == glsl_type::float_type);
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
2010-09-07 23:22:10 -07:00
|
|
|
assert(ir->operands[0]->type->is_vector());
|
2010-07-27 09:01:30 -07:00
|
|
|
assert(ir->operands[0]->type == ir->operands[1]->type);
|
|
|
|
break;
|
2010-11-16 12:01:42 -08:00
|
|
|
|
2012-11-19 10:48:25 -08:00
|
|
|
case ir_binop_pack_half_2x16_split:
|
|
|
|
assert(ir->type == glsl_type::uint_type);
|
|
|
|
assert(ir->operands[0]->type == glsl_type::float_type);
|
|
|
|
assert(ir->operands[1]->type == glsl_type::float_type);
|
|
|
|
break;
|
|
|
|
|
glsl: Add a "ubo_load" expression type for fetches from UBOs.
Drivers will probably want to be able to take UBO references in a
shader like:
uniform ubo1 {
float a;
float b;
float c;
float d;
}
void main() {
gl_FragColor = vec4(a, b, c, d);
}
and generate a single aligned vec4 load out of the UBO. For intel,
this involves recognizing the shared offset of the aligned loads and
CSEing them out. Obviously that involves breaking things down to
loads from an offset from a particular UBO first. Thus, the driver
doesn't want to see
variable_ref(ir_variable("a")),
and even more so does it not want to see
array_ref(record_ref(variable_ref(ir_variable("a")),
"field1"), variable_ref(ir_variable("i"))).
where a.field1[i] is a row_major matrix.
Instead, we're going to make a lowering pass to break UBO references
down to expressions that are obvious to codegen, and amenable to
merging through CSE.
v2: Fix some partial thoughts in the ir_binop comment (review by Kenneth)
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
2012-07-09 15:52:53 -07:00
|
|
|
case ir_binop_ubo_load:
|
|
|
|
assert(ir->operands[0]->as_constant());
|
|
|
|
assert(ir->operands[0]->type == glsl_type::uint_type);
|
|
|
|
|
|
|
|
assert(ir->operands[1]->type == glsl_type::uint_type);
|
|
|
|
break;
|
|
|
|
|
2012-12-01 23:49:26 -08:00
|
|
|
case ir_triop_lrp:
|
|
|
|
assert(ir->operands[0]->type->base_type == GLSL_TYPE_FLOAT);
|
|
|
|
assert(ir->operands[0]->type == ir->operands[1]->type);
|
|
|
|
assert(ir->operands[2]->type == ir->operands[0]->type || ir->operands[2]->type == glsl_type::float_type);
|
|
|
|
break;
|
|
|
|
|
2010-11-16 12:01:42 -08:00
|
|
|
case ir_quadop_vector:
|
|
|
|
/* The vector operator collects some number of scalars and generates a
|
|
|
|
* vector from them.
|
|
|
|
*
|
|
|
|
* - All of the operands must be scalar.
|
|
|
|
* - Number of operands must matche the size of the resulting vector.
|
|
|
|
* - Base type of the operands must match the base type of the result.
|
|
|
|
*/
|
|
|
|
assert(ir->type->is_vector());
|
|
|
|
switch (ir->type->vector_elements) {
|
|
|
|
case 2:
|
|
|
|
assert(ir->operands[0]->type->is_scalar());
|
|
|
|
assert(ir->operands[0]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[1]->type->is_scalar());
|
|
|
|
assert(ir->operands[1]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[2] == NULL);
|
|
|
|
assert(ir->operands[3] == NULL);
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
assert(ir->operands[0]->type->is_scalar());
|
|
|
|
assert(ir->operands[0]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[1]->type->is_scalar());
|
|
|
|
assert(ir->operands[1]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[2]->type->is_scalar());
|
|
|
|
assert(ir->operands[2]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[3] == NULL);
|
|
|
|
break;
|
|
|
|
case 4:
|
|
|
|
assert(ir->operands[0]->type->is_scalar());
|
|
|
|
assert(ir->operands[0]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[1]->type->is_scalar());
|
|
|
|
assert(ir->operands[1]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[2]->type->is_scalar());
|
|
|
|
assert(ir->operands[2]->type->base_type == ir->type->base_type);
|
|
|
|
assert(ir->operands[3]->type->is_scalar());
|
|
|
|
assert(ir->operands[3]->type->base_type == ir->type->base_type);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
/* The is_vector assertion above should prevent execution from ever
|
|
|
|
* getting here.
|
|
|
|
*/
|
|
|
|
assert(!"Should not get here.");
|
|
|
|
break;
|
|
|
|
}
|
2010-07-27 09:01:30 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2010-09-27 15:48:15 -07:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_leave(ir_swizzle *ir)
|
|
|
|
{
|
2012-03-13 16:05:26 +00:00
|
|
|
unsigned int chans[4] = {ir->mask.x, ir->mask.y, ir->mask.z, ir->mask.w};
|
2010-09-27 15:48:15 -07:00
|
|
|
|
|
|
|
for (unsigned int i = 0; i < ir->type->vector_elements; i++) {
|
|
|
|
if (chans[i] >= ir->val->type->vector_elements) {
|
|
|
|
printf("ir_swizzle @ %p specifies a channel not present "
|
|
|
|
"in the value.\n", (void *) ir);
|
|
|
|
ir->print();
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2010-06-22 12:07:21 -07:00
|
|
|
ir_visitor_status
|
2010-06-22 18:41:50 -07:00
|
|
|
ir_validate::visit(ir_variable *ir)
|
2010-06-22 12:07:21 -07:00
|
|
|
{
|
2010-06-22 18:41:50 -07:00
|
|
|
/* An ir_variable is the one thing that can (and will) appear multiple times
|
2010-07-12 13:55:32 -07:00
|
|
|
* in an IR tree. It is added to the hashtable so that it can be used
|
|
|
|
* in the ir_dereference_variable handler to ensure that a variable is
|
|
|
|
* declared before it is dereferenced.
|
2010-06-22 18:41:50 -07:00
|
|
|
*/
|
2010-08-03 11:43:25 -07:00
|
|
|
if (ir->name)
|
2011-01-21 14:32:31 -08:00
|
|
|
assert(ralloc_parent(ir->name) == ir);
|
2010-08-02 12:08:52 -07:00
|
|
|
|
2010-07-12 13:55:32 -07:00
|
|
|
hash_table_insert(ht, ir, ir);
|
2011-03-24 16:49:21 -07:00
|
|
|
|
|
|
|
|
|
|
|
/* If a variable is an array, verify that the maximum array index is in
|
|
|
|
* bounds. There was once an error in AST-to-HIR conversion that set this
|
|
|
|
* to be out of bounds.
|
|
|
|
*/
|
|
|
|
if (ir->type->array_size() > 0) {
|
|
|
|
if (ir->max_array_access >= ir->type->length) {
|
|
|
|
printf("ir_variable has maximum access out of bounds (%d vs %d)\n",
|
|
|
|
ir->max_array_access, ir->type->length - 1);
|
|
|
|
ir->print();
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-31 14:31:07 -07:00
|
|
|
if (ir->constant_initializer != NULL && !ir->has_initializer) {
|
|
|
|
printf("ir_variable didn't have an initializer, but has a constant "
|
|
|
|
"initializer value.\n");
|
|
|
|
ir->print();
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2010-06-22 12:07:21 -07:00
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2010-08-04 16:27:17 -07:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_enter(ir_assignment *ir)
|
|
|
|
{
|
|
|
|
const ir_dereference *const lhs = ir->lhs;
|
|
|
|
if (lhs->type->is_scalar() || lhs->type->is_vector()) {
|
|
|
|
if (ir->write_mask == 0) {
|
|
|
|
printf("Assignment LHS is %s, but write mask is 0:\n",
|
|
|
|
lhs->type->is_scalar() ? "scalar" : "vector");
|
|
|
|
ir->print();
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2010-09-22 11:47:03 -07:00
|
|
|
int lhs_components = 0;
|
|
|
|
for (int i = 0; i < 4; i++) {
|
|
|
|
if (ir->write_mask & (1 << i))
|
|
|
|
lhs_components++;
|
|
|
|
}
|
2010-08-04 16:27:17 -07:00
|
|
|
|
2010-09-22 11:47:03 -07:00
|
|
|
if (lhs_components != ir->rhs->type->vector_elements) {
|
|
|
|
printf("Assignment count of LHS write mask channels enabled not\n"
|
|
|
|
"matching RHS vector size (%d LHS, %d RHS).\n",
|
|
|
|
lhs_components, ir->rhs->type->vector_elements);
|
2010-08-04 16:27:17 -07:00
|
|
|
ir->print();
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
this->validate_ir(ir, this->data);
|
|
|
|
|
|
|
|
return visit_continue;
|
|
|
|
}
|
|
|
|
|
2011-03-07 15:13:06 -08:00
|
|
|
ir_visitor_status
|
|
|
|
ir_validate::visit_enter(ir_call *ir)
|
|
|
|
{
|
2011-09-20 18:08:11 -07:00
|
|
|
ir_function_signature *const callee = ir->callee;
|
2011-03-07 15:13:06 -08:00
|
|
|
|
|
|
|
if (callee->ir_type != ir_type_function_signature) {
|
|
|
|
printf("IR called by ir_call is not ir_function_signature!\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
glsl: Convert ir_call to be a statement rather than a value.
Aside from ir_call, our IR is cleanly split into two classes:
- Statements (typeless; used for side effects, control flow)
- Values (deeply nestable, pure, typed expression trees)
Unfortunately, ir_call confused all this:
- For void functions, we placed ir_call directly in the instruction
stream, treating it as an untyped statement. Yet, it was a subclass
of ir_rvalue, and no other ir_rvalue could be used in this way.
- For functions with a return value, ir_call could be placed in
arbitrary expression trees. While this fit naturally with the source
language, it meant that expressions might not be pure, making it
difficult to transform and optimize them. To combat this, we always
emitted ir_call directly in the RHS of an ir_assignment, only using
a temporary variable in expression trees. Many passes relied on this
assumption; the acos and atan built-ins violated it.
This patch makes ir_call a statement (ir_instruction) rather than a
value (ir_rvalue). Non-void calls now take a ir_dereference of a
variable, and store the return value there---effectively a call and
assignment rolled into one. They cannot be embedded in expressions.
All expression trees are now pure, without exception.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
2012-03-20 15:56:37 -07:00
|
|
|
if (ir->return_deref) {
|
|
|
|
if (ir->return_deref->type != callee->return_type) {
|
|
|
|
printf("callee type %s does not match return storage type %s\n",
|
|
|
|
callee->return_type->name, ir->return_deref->type->name);
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
} else if (callee->return_type != glsl_type::void_type) {
|
|
|
|
printf("ir_call has non-void callee but no return storage\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
|
2011-08-02 15:44:39 -07:00
|
|
|
const exec_node *formal_param_node = callee->parameters.head;
|
|
|
|
const exec_node *actual_param_node = ir->actual_parameters.head;
|
|
|
|
while (true) {
|
|
|
|
if (formal_param_node->is_tail_sentinel()
|
|
|
|
!= actual_param_node->is_tail_sentinel()) {
|
|
|
|
printf("ir_call has the wrong number of parameters:\n");
|
|
|
|
goto dump_ir;
|
|
|
|
}
|
|
|
|
if (formal_param_node->is_tail_sentinel()) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
const ir_variable *formal_param
|
|
|
|
= (const ir_variable *) formal_param_node;
|
|
|
|
const ir_rvalue *actual_param
|
|
|
|
= (const ir_rvalue *) actual_param_node;
|
|
|
|
if (formal_param->type != actual_param->type) {
|
|
|
|
printf("ir_call parameter type mismatch:\n");
|
|
|
|
goto dump_ir;
|
|
|
|
}
|
2013-01-11 14:39:32 -08:00
|
|
|
if (formal_param->mode == ir_var_function_out
|
|
|
|
|| formal_param->mode == ir_var_function_inout) {
|
2011-08-02 15:44:39 -07:00
|
|
|
if (!actual_param->is_lvalue()) {
|
|
|
|
printf("ir_call out/inout parameters must be lvalues:\n");
|
|
|
|
goto dump_ir;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
formal_param_node = formal_param_node->next;
|
|
|
|
actual_param_node = actual_param_node->next;
|
|
|
|
}
|
|
|
|
|
2011-03-07 15:13:06 -08:00
|
|
|
return visit_continue;
|
2011-08-02 15:44:39 -07:00
|
|
|
|
|
|
|
dump_ir:
|
|
|
|
ir->print();
|
|
|
|
printf("callee:\n");
|
|
|
|
callee->print();
|
|
|
|
abort();
|
2011-12-01 16:37:49 -07:00
|
|
|
return visit_stop;
|
2011-03-07 15:13:06 -08:00
|
|
|
}
|
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
void
|
|
|
|
ir_validate::validate_ir(ir_instruction *ir, void *data)
|
2010-06-22 12:07:21 -07:00
|
|
|
{
|
2010-06-22 18:41:50 -07:00
|
|
|
struct hash_table *ht = (struct hash_table *) data;
|
2010-06-22 12:07:21 -07:00
|
|
|
|
2010-06-22 18:41:50 -07:00
|
|
|
if (hash_table_find(ht, ir)) {
|
|
|
|
printf("Instruction node present twice in ir tree:\n");
|
|
|
|
ir->print();
|
|
|
|
printf("\n");
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
hash_table_insert(ht, ir, ir);
|
2010-06-22 12:07:21 -07:00
|
|
|
}
|
|
|
|
|
2010-07-19 09:05:42 -07:00
|
|
|
void
|
|
|
|
check_node_type(ir_instruction *ir, void *data)
|
|
|
|
{
|
2010-08-02 11:46:22 -07:00
|
|
|
(void) data;
|
|
|
|
|
2010-07-19 09:05:42 -07:00
|
|
|
if (ir->ir_type <= ir_type_unset || ir->ir_type >= ir_type_max) {
|
|
|
|
printf("Instruction node with unset type\n");
|
|
|
|
ir->print(); printf("\n");
|
|
|
|
}
|
2011-09-20 17:58:45 -07:00
|
|
|
ir_rvalue *value = ir->as_rvalue();
|
|
|
|
if (value != NULL)
|
|
|
|
assert(value->type != glsl_type::error_type);
|
2010-07-19 09:05:42 -07:00
|
|
|
}
|
|
|
|
|
2010-06-22 12:07:21 -07:00
|
|
|
void
|
|
|
|
validate_ir_tree(exec_list *instructions)
|
|
|
|
{
|
|
|
|
ir_validate v;
|
|
|
|
|
|
|
|
v.run(instructions);
|
2010-07-19 09:05:42 -07:00
|
|
|
|
|
|
|
foreach_iter(exec_list_iterator, iter, *instructions) {
|
|
|
|
ir_instruction *ir = (ir_instruction *)iter.get();
|
|
|
|
|
|
|
|
visit_tree(ir, check_node_type, NULL);
|
|
|
|
}
|
2010-06-22 12:07:21 -07:00
|
|
|
}
|